Skip to content

fix(material/slider): update VI when toggling discrete #25985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2022
Merged

fix(material/slider): update VI when toggling discrete #25985

merged 3 commits into from
Nov 17, 2022

Conversation

wagnermaciel
Copy link
Contributor

  • Fixes an issue where the value indicator ui is not initialized when toggling discrete on

@wagnermaciel
fix(material/slider): update VI when toggling discrete
b10deb0 
* Fixes an issue where the value indicator ui is not
  initialized when toggling discrete on
devversion
devversion approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you could likely extract that into a reusable helper.

@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Nov 16, 2022
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2022
@wagnermaciel wagnermaciel merged commit a582e0a into angular:main Nov 17, 2022
wagnermaciel added a commit that referenced this pull request Nov 17, 2022
@wagnermaciel
fix(material/slider): update VI when toggling discrete (#25985)
dcde768 
* fix(material/slider): update VI when toggling discrete

* Fixes an issue where the value indicator ui is not
  initialized when toggling discrete on

* fixup! fix(material/slider): update VI when toggling discrete

* fixup! fix(material/slider): update VI when toggling discrete

(cherry picked from commit a582e0a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagnermaciel @devversion