Skip to content

build: setup remote execution for dev-app preview action #25982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

build: setup remote execution for dev-app preview action #25982

merged 1 commit into from
Nov 16, 2022

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion force-pushed the setup-remote-exec-dev-app-preview branch from 87b6eaa to cf3ced3 Compare November 15, 2022 15:51
@devversion devversion added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 15, 2022
@devversion devversion force-pushed the setup-remote-exec-dev-app-preview branch from cf3ced3 to c1809cb Compare November 15, 2022 18:27
@github-actions
Copy link

Deployed dev-app to: https://ng-comp-dev--pr-25982-c1809cbfd53825084bc07c404691b7ec-7g0gfvkj.web.app

@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 15, 2022
@devversion devversion marked this pull request as ready for review November 15, 2022 18:41
josephperrott
josephperrott approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 16, 2022
@devversion devversion merged commit a0f6dab into angular:main Nov 16, 2022
devversion added a commit that referenced this pull request Nov 16, 2022
@devversion
build: setup remote execution for dev-app preview action (#25982)
76603ad 
(cherry picked from commit a0f6dab)
devversion added a commit that referenced this pull request Nov 16, 2022
@devversion
build: setup remote execution for dev-app preview action (#25982)
02d122a 
(cherry picked from commit a0f6dab)
@devversion devversion deleted the setup-remote-exec-dev-app-preview branch November 16, 2022 15:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @crisbeto @josephperrott