Skip to content

docs: add example for variants of mdc list #25971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 14, 2022

@mmalerba @crisbeto I thought we may want to show the different variants of lists since that is
very unclear from the docs right now, especially showing some cases of the API.

The example is more of a "documentation as code", show-casing some ways of rendering stuff
and the given markup. Let me know what you think

image

Note: Notice how there is an additional space when a line is in unscoped content and not part of e.g. a <span>. I wanted to keep this though as it shows that the last line doesn't necessarily need to be part of a matListItemLine/Title and was hoping this would make it more clear. Happy to remove these though.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 14, 2022
@devversion devversion added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 14, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels Nov 15, 2022
@devversion devversion merged commit cd52117 into angular:main Nov 15, 2022
devversion added a commit that referenced this pull request Nov 15, 2022
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Nov 16, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants