fix(material/chips): fix state layer interferring with text color #25892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
zarend
force-pushed
the
mdc-chips-state-layer
branch
from
92b3722 to
120d651
Compare
|
@crisbeto I've converted this to a real PR and it's ready for your eyes 👀 |
crisbeto
reviewed
Nov 1, 2022
zarend
force-pushed
the
mdc-chips-state-layer
branch
from
120d651 to
43fc378
Compare
Make focus overlay not affect the text color. Give the text label a higher z-index than the focus overlay to ensure that it does not affect the text color. Material spec requires that state layer does not interfere with text color. Fix issue where focus overlay would be on top of the text and darken the color of the text. This is a deviation from spec and causes a11y issues due to insufficient text contrast.
zarend
force-pushed
the
mdc-chips-state-layer
branch
from
43fc378 to
6dc3476
Compare
zarend
added
target: minor
zarend
added a commit
that referenced
this pull request
Nov 16, 2022
Make focus overlay not affect the text color. Give the text label a higher z-index than the focus overlay to ensure that it does not affect the text color. Material spec requires that state layer does not interfere with text color. Fix issue where focus overlay would be on top of the text and darken the color of the text. This is a deviation from spec and causes a11y issues due to insufficient text contrast. (cherry picked from commit 29f6b6b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where state layer interfers with color of the text. Give the text label a higher z-index than the focus overlay.