fix(core/mat-option): don't remove aria-selected from deselected options #25749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
zarend
force-pushed
the
mat-option-aria-selected
branch
from
3368086 to
95bd6f5
Compare
|
Draft. Here is remaining work before this converts to a real PR
|
zarend
force-pushed
the
mat-option-aria-selected
branch
4 times, most recently
from
16d67d7 to
f198ec2
Compare
crisbeto
reviewed
Oct 6, 2022
zarend
force-pushed
the
mat-option-aria-selected
branch
2 times, most recently
from
494cc1e to
c5ec0e3
Compare
|
responded to comments, and this is ready for review again 👀 |
crisbeto
reviewed
Oct 7, 2022
src/material/core/option/option.ts
Outdated
| @@ -243,6 +233,19 @@ export class _MatOptionBase<T = any> implements FocusableOption, AfterViewChecke | |||
|
|
|||
| /** | |||
| * Single option inside of a `<mat-select>` element. | |||
| * | |||
| * The aria-selected attribute applied to the option conforms to WAI ARIA best practices for listbox | |||
There was a problem hiding this comment.
We shouldn't put the aria-selected explanation here, because it's going to show up in the docs site. It can be put right before the '[attr.aria-selected]': 'selected', on line 261.
zarend
force-pushed
the
mat-option-aria-selected
branch
from
c5ec0e3 to
c31f13a
Compare
For mat-option, set `aria-selected="false"` on deselected options that are selectable. Conforms with [WAI ARIA Listbox authoring practices guide]( https://www.w3.org/WAI/ARIA/apg/patterns/listbox/), which says to always include aria-selected attribute on options that are selectable. Fix issue where voiceover reads every option as "selected" (angular#25736). Fix angular#25736
zarend
force-pushed
the
mat-option-aria-selected
branch
from
c31f13a to
ac9e95d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mat-option, set
aria-selected="false"on deselected options that are selectable. Conforms with WAI ARIA Listbox authoring practices guide, which says to always include aria-selected attribute on options that are selectable. Fix issue where voiceover reads every option as "selected" (#25736).Fix #25736