Skip to content

docs(slide-toggle): migrate examples to MDC #25643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2022
Merged

docs(slide-toggle): migrate examples to MDC #25643

merged 1 commit into from
Sep 16, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Sep 14, 2022

Migrate slide-toggle example to use mdc-based components.

@zarend zarend added docs This issue is related to documentation merge safe area: material/slide-toggle labels Sep 14, 2022
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 14, 2022
@zarend zarend force-pushed the slide-toggle-mdc-examples branch from 1ff8b79 to 9784a26 Compare September 14, 2022 22:41
crisbeto
crisbeto reviewed Sep 15, 2022
View reviewed changes
@zarend zarend marked this pull request as draft September 15, 2022 15:26
@zarend zarend added the target: major This PR is targeted for the next major release label Sep 15, 2022
@zarend zarend force-pushed the slide-toggle-mdc-examples branch 2 times, most recently from 62c8da7 to edfd63e Compare September 15, 2022 18:46
@zarend
docs(material/slide-toggle): migrate examples to MDC
192af0e 
Migrate slide-toggle example to use mdc-based components.
@zarend zarend force-pushed the slide-toggle-mdc-examples branch from edfd63e to 192af0e Compare September 15, 2022 18:51
@zarend
Copy link
Contributor Author

zarend commented Sep 15, 2022

  • brought back the inline demo
  • fixed component harness example
    This PR is ready for review again.

@zarend zarend marked this pull request as ready for review September 15, 2022 18:51
crisbeto
crisbeto approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 16, 2022
@zarend zarend merged commit 3761275 into angular:main Sep 16, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Sep 16, 2022
@zarend
docs(material/slide-toggle): migrate examples to MDC (angular#25643)
0e263a9 
Migrate slide-toggle example to use mdc-based components.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/slide-toggle docs This issue is related to documentation target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarend @crisbeto