docs(material/select): Disabling the select or individual options #25065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Jun 12, 2022
src/material/select/select.md
Outdated
| @@ -54,6 +54,9 @@ In some cases that `<mat-form-field>` may use the placeholder as the label (see | |||
|
|
|||
| It is possible to disable the entire select or individual options in the select by using the | |||
| disabled property on the `<select>` or `<mat-select>` and the `<option>` or `<mat-option>` elements respectively. | |||
| When working with Reactive Forms the select component can be disabled/enabled via form controls. | |||
| This can be accomplished by creating a FormControl with the disabled property | |||
There was a problem hiding this comment.
There should be backticks around "FormControl" here.
src/material/select/select.md
Outdated
| @@ -54,6 +54,9 @@ In some cases that `<mat-form-field>` may use the placeholder as the label (see | |||
|
|
|||
| It is possible to disable the entire select or individual options in the select by using the | |||
| disabled property on the `<select>` or `<mat-select>` and the `<option>` or `<mat-option>` elements respectively. | |||
| When working with Reactive Forms the select component can be disabled/enabled via form controls. | |||
There was a problem hiding this comment.
nit: there should be a comma between "Forms" and "the".
jljohnson001
changed the title
Update documentation to include ReactiveForms use case Fixes angular#24762
Update documentation to include ReactiveForms use case Fixes angular#24762
PR Feedback (add comma, add backticks) Fixes angular#24762
jljohnson001
force-pushed
the
jljohnson001-fix-docs-mat-select
branch
from
b8a40f9 to
7c2c14d
Compare
crisbeto
added
docs
crisbeto
approved these changes
Jun 12, 2022
crisbeto
pushed a commit
that referenced
this pull request
Jun 12, 2022
…ual options (#25065) * docs(material/select): Disabling the select or individual options Update documentation to include ReactiveForms use case Fixes #24762 * docs(material/select): Disabling the select or individual options Update documentation to include ReactiveForms use case Fixes #24762 * docs(material/select): Disabling the select or individual options PR Feedback (add comma, add backticks) Fixes #24762 (cherry picked from commit aadcb96)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to include ReactiveForms use case
Fixes #24762