Skip to content

refactor(material/bottom-sheet): use CDK dialog internally #24951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

refactor(material/bottom-sheet): use CDK dialog internally #24951

merged 1 commit into from
May 23, 2022

Conversation

crisbeto
Copy link
Member

Switches the internals of the bottom sheet to use the CDK dialog.

@crisbeto
refactor(material/bottom-sheet): use CDK dialog internally
1f25d2c 
Switches the internals of the bottom sheet to use the CDK dialog.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels May 21, 2022
wagnermaciel
wagnermaciel approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 23, 2022
@crisbeto crisbeto self-assigned this May 23, 2022
zarend
zarend approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto merged commit 64b6506 into angular:main May 23, 2022
crisbeto added a commit that referenced this pull request May 23, 2022
@crisbeto
refactor(material/bottom-sheet): use CDK dialog internally (#24951)
4fb51a0 
Switches the internals of the bottom sheet to use the CDK dialog.

(cherry picked from commit 64b6506)
@crisbeto crisbeto mentioned this pull request Jun 7, 2022
Closed
1 task
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zarend zarend zarend approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @zarend @wagnermaciel