refactor(cdk/menu): use inject for all injection
#24941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P2
jelbourn
changed the title
inject for all injection
jelbourn
changed the title
inject for all injectioninject for all injection
jelbourn
force-pushed
the
menu-injection
branch
2 times, most recently
from
0342974 to
7403ce8
Compare
crisbeto
reviewed
May 19, 2022
src/cdk/menu/menu-trigger-base.ts
Outdated
| protected readonly viewContainerRef = inject(ViewContainerRef); | ||
|
|
||
| /** The menu stack in which this menu resides. */ | ||
| protected readonly menuStack: MenuStack | null = inject(MENU_STACK, InjectFlags.Optional); |
There was a problem hiding this comment.
Why is this optional now? It used to be required. It causes some extra null checks in the components extending this one.
There was a problem hiding this comment.
Bad copy and paste, removed the optional
jelbourn
force-pushed
the
menu-injection
branch
2 times, most recently
from
3a49f30 to
dc200d7
Compare
|
CI failures are resolved. I had to disable the no bitwise operator lint since it's required for this API |
|
Made another update to remove some unnecessary explicit types. e.g., if you have class MenuTrigger {
menuAim = inject(MENU_AIM, InjectFlags.Optional);
}it will automatically infer |
|
Looks like still some lint & api failures |
|
Whoops, I had it green and then messed up the formatting when I made that last edit. Fixed. |
mmalerba
previously approved these changes
May 20, 2022
This change switches the cdk menu from using constructor injection to using the `inject` function. This was enabled by angular/angular#45991. This approach has a number of advantages: * We can add and remove injectables without changing the public constructor signature * It reduces the boilerplate of passing arguments through `super` * It avoids long/messy constructor blocks in favor of simpler member definitions. * This sidesteps a common pitfall of making `@Optional` injection (`null` if not provided) as an optional parameter (`undefined` if not provided)`.
mmalerba
approved these changes
May 20, 2022
mmalerba
pushed a commit
that referenced
this pull request
May 23, 2022
This change switches the cdk menu from using constructor injection to using the `inject` function. This was enabled by angular/angular#45991. This approach has a number of advantages: * We can add and remove injectables without changing the public constructor signature * It reduces the boilerplate of passing arguments through `super` * It avoids long/messy constructor blocks in favor of simpler member definitions. * This sidesteps a common pitfall of making `@Optional` injection (`null` if not provided) as an optional parameter (`undefined` if not provided)`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches the cdk menu from using constructor injection to using the
injectfunction. This was enabled by angular/angular#45991. This approach has a number of advantages:super@Optionalinjection (nullif not provided) as an optional parameter (undefinedif not provided).I expect this PR to involve some discussion around how we want to approach this in general.