Skip to content

test(material/button): use withContext to show fail output #24937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

test(material/button): use withContext to show fail output #24937

merged 1 commit into from
May 18, 2022

Conversation

damingerdai
Copy link
Contributor

No description provided.

@damingerdai damingerdai requested a review from andrewseguin as a code owner May 18, 2022 14:19
crisbeto
crisbeto approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 18, 2022
@crisbeto crisbeto merged commit b2e6d7e into angular:main May 18, 2022
crisbeto pushed a commit that referenced this pull request May 18, 2022
@damingerdai @crisbeto
test(material/button): use withContext to expact fail output (#24937)
47ce621 
(cherry picked from commit b2e6d7e)
@damingerdai damingerdai deleted the button-test-toBeTruthy branch May 18, 2022 23:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damingerdai @crisbeto