Skip to content

build: update to TypeScript 4.7 #24880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

build: update to TypeScript 4.7 #24880

merged 1 commit into from
May 5, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 5, 2022

Bumps up our version of TypeScript to 4.7 and resolves a couple of build errors.

@@ -19,5 +19,6 @@
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
}
},
"typescript.tsdk": "node_modules/typescript/lib"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was added by vscode automatically. I don't mind reverting it, but it seems reasonable. It tells vscode to use the local version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good idea 👍

@crisbeto crisbeto force-pushed the ts-4.7 branch 4 times, most recently from 0c2d890 to 47556d8 Compare May 5, 2022 08:11
Bumps up our version of TypeScript to 4.7 and resolves a couple of build errors.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 5, 2022
@crisbeto crisbeto marked this pull request as ready for review May 5, 2022 09:38
@crisbeto crisbeto requested review from a team, mmalerba, andrewseguin and devversion as code owners May 5, 2022 09:38
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels May 5, 2022
@crisbeto crisbeto merged commit b80d11b into angular:main May 5, 2022
crisbeto added a commit that referenced this pull request May 5, 2022
Bumps up our version of TypeScript to 4.7 and resolves a couple of build errors.

(cherry picked from commit b80d11b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants