Skip to content

update(overlay): use boolean-property coercion function #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2017
Merged

update(overlay): use boolean-property coercion function #2487

merged 1 commit into from
Jan 6, 2017

Conversation

devversion
Copy link
Member

  • Replaces the coercion logic in the hasBackdrop method with the coerceBooleanProperty utility function.

@devversion
update(overlay): use boolean-property coercion function
707f249 
* Replaces the coercion logic in the `hasBackdrop` method  with the `coerceBooleanProperty` utility function.
@devversion devversion requested a review from jelbourn January 1, 2017 17:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 1, 2017
@jelbourn
Copy link
Member

jelbourn commented Jan 3, 2017

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 3, 2017
@kara kara merged commit 55e5686 into angular:master Jan 6, 2017
@devversion devversion deleted the update/overlay-use-coercion branch January 6, 2017 21:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @kara @googlebot