Skip to content

refactor(material/dialog): switch to CDK dialog internally #24857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 1, 2022

Switches the Material dialog to be based on the CDK dialog.

@crisbeto crisbeto force-pushed the mat-dialog-cdk branch 3 times, most recently from 4223168 to 578b977 Compare May 1, 2022 07:45
@crisbeto crisbeto marked this pull request as ready for review May 1, 2022 07:45
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 1, 2022
@crisbeto crisbeto requested review from a team and jelbourn as code owners May 1, 2022 10:04
@crisbeto crisbeto force-pushed the mat-dialog-cdk branch 3 times, most recently from e57f259 to 525f253 Compare May 1, 2022 16:27
@crisbeto crisbeto marked this pull request as draft May 1, 2022 18:26
@crisbeto crisbeto closed this May 2, 2022
@crisbeto crisbeto reopened this May 2, 2022
@crisbeto crisbeto force-pushed the mat-dialog-cdk branch 2 times, most recently from 7feb298 to 54bae80 Compare May 2, 2022 09:03
Switches the Material dialog to be based on the CDK dialog.
@crisbeto crisbeto marked this pull request as ready for review May 3, 2022 08:40
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 3, 2022
@crisbeto crisbeto merged commit fb9ff16 into angular:main May 3, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants