fix(material-experimental/mdc-checkbox): remove extra a11y tree node for the <label/> #24839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
|
Deployed dev-app to: https://ng-comp-dev--pr-24839-74aee29baffc3d8d50ac67775da2dfc1-yo8570kz.web.app |
crisbeto
reviewed
Apr 29, 2022
…for the <label/> In the mdc checkbox component, moves the click handler on the label to its parent, the .mdc-checkbox. This removes the extra a11y tree node on the label and fixes TalkBack having an extra navigation stop (angular#14385). A11y tree before this commit. It has an un-necessary node, which coresponds to the `<label>` element. ``` - Generic - Checkbox, "Field A" - Textlabel, "Field A" ``` A11y tree with this commit applied ``` - Generic - Checkbox, "Field A" ``` fixes angular#14385
zarend
force-pushed
the
checkbox-label-a11y-tree
branch
from
bdd024f to
74aee29
Compare
mmalerba
approved these changes
May 3, 2022
|
This causes a style regression because styles rules with this selector no longer match: |
|
closing in favor of #24907 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mdc checkbox component, moves the click handler on the label to
its parent, the .mdc-checkbox. This removes the extra a11y
tree node on the label and fixes TalkBack having an extra navigation
stop (#14385).
A11y tree before this commit. It has an un-necessary node, which
coresponds to the
<label>element.A11y tree with this commit applied
fixes #14385