Skip to content

build: update to nodejs v16.14.0 and switch away from deprecated docker image #24579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

devversion
Copy link
Member

See individual commits

@devversion devversion force-pushed the deprecated-circleci-images branch from 6e0079a to 95cb4ed Compare March 11, 2022 16:21
@devversion devversion requested a review from crisbeto March 11, 2022 16:21
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 11, 2022
@devversion devversion marked this pull request as ready for review March 11, 2022 16:22
@devversion devversion requested a review from a team as a code owner March 11, 2022 16:22
@devversion devversion force-pushed the deprecated-circleci-images branch from 95cb4ed to 9b4df14 Compare March 11, 2022 16:22
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2022
@devversion
Copy link
Member Author

FYI: The ci/angular: merge status pending state is okay for this PR. Once this PR is merged, it will work as expected

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend merged commit e11fb00 into angular:master Mar 14, 2022
zarend pushed a commit that referenced this pull request Mar 14, 2022
…er image (#24579)

* build: update to nodejs v16.14.0 and switch away from deprecated docker image

https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034

* ci: stop using browsers image for browser test job using remote execution

Tests running with remote execution do not rely on the host environemnt so
we do not need the browsers image.

(cherry picked from commit e11fb00)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…er image (angular#24579)

* build: update to nodejs v16.14.0 and switch away from deprecated docker image

https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034

* ci: stop using browsers image for browser test job using remote execution

Tests running with remote execution do not rely on the host environemnt so
we do not need the browsers image.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants