feat(cdk/tree): add tests for the new cdk/tree APIs

[BobobUnicorn]

Followed by #25729.

[BobobUnicorn]

@andrewseguin this is a straight migration of the existing tests just using the non-deprecated APIs

[andrewseguin]

This seems like a strange change - wouldn't this only want to take one look at the descendants? Would this emit multiple times over the course of the component?

[BobobUnicorn]

_getAllDecendants emits multiple times, but does only call getDescendants once per node

[jelbourn]

Could you add a comment here (above this._getAllDescendants()) that explains what's happening here?

My mental model here is that _getAllDescendants is an observable because descendants may change over time, but the expandAll and collapseAll operations happen at a single point in time. My expectation would be that you would still want take(1) here with _getAllDescendants not emitting until it has accumulated all nodes.

[BobobUnicorn]

I've added a text blurb above the _getAllDescendants function instead, does that clarify things?

[jelbourn]

Could you add a comment here (above this._getAllDescendants()) that explains what's happening here?

My mental model here is that _getAllDescendants is an observable because descendants may change over time, but the expandAll and collapseAll operations happen at a single point in time. My expectation would be that you would still want take(1) here with _getAllDescendants not emitting until it has accumulated all nodes.

[andrewseguin]

Run yarn bazel run //tools/public_api_guard:cdk/tree.md_api.accept to update the goldens

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}