feat(material/autocomplete): test harness should throw when options are requested but panel is closed #24494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re requested but panel is closed The autocomplete harness has methods for retrieving the options of an autocomplete. When this method is invoked, the options are determined from the overlay DOM element, if available. If the panel is not in the DOM (due to the autocomplete not being focused), the method will just return an empty array, indicating that there are no options. This is confusing for test authors and currently not well-defined, potentially causing invalid tests that just pass by coincidence. We want to throw when the panel is not open, raising awareness for such invalid tests. In the future we may want to auto-focus the autocomplete to open the panel (like `selectOption`).
devversion
force-pushed
the
select-error-options-panel-closed
branch
from
3b12a0f to
ac7df56
Compare
devversion
changed the title
devversion
added
the
target: minor
andrewseguin
approved these changes
Feb 28, 2022
|
Looking forward to seeing all the failing tests that thought the panel was open.... |
|
Only 31 clients needed to be changed =P |
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…re requested but panel is closed (angular#24494) The autocomplete harness has methods for retrieving the options of an autocomplete. When this method is invoked, the options are determined from the overlay DOM element, if available. If the panel is not in the DOM (due to the autocomplete not being focused), the method will just return an empty array, indicating that there are no options. This is confusing for test authors and currently not well-defined, potentially causing invalid tests that just pass by coincidence. We want to throw when the panel is not open, raising awareness for such invalid tests. In the future we may want to auto-focus the autocomplete to open the panel (like `selectOption`).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autocomplete harness has methods for retrieving the options of an
autocomplete. When this method is invoked, the options are determined
from the overlay DOM element, if available. If the panel is not in the DOM
(due to the autocomplete not being focused), the method will just return
an empty array, indicating that there are no options.
This is confusing for test authors and currently not well-defined, potentially
causing invalid tests that just pass by coincidence.
We want to throw when the panel is not open, raising awareness for such invalid
tests. In the future we may want to auto-focus the autocomplete to open the
panel (like
selectOption).