build: use less ambiguous peer dependency to Angular framework #24425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: minor
andrewseguin
approved these changes
Feb 16, 2022
Our current peer dependency for Angular CDK/Material v13, also allow for Angular `v14.0.0-0`. This might work practically since Angular FW v14 is usually compatible with Angular N-1 versions. Although this peer dependency version is currently a little ambiguous since it does not allow all v14 pre-releases. Rather as per NPMs definition, the current range does only allow for `v14.x.y` and `v14.0.0-(next|rc).X` (excluding pre-releases for other minors) It seems like it would be best to avoid this pre-release addition in general to avoid this ambiguity/inconsistency, while also fixing angular/angular-cli#22654. In general, it seems reasonable to say that Angular CDK v13 is compatible with Angular FW v13, and Angular FW v14 (both of these ranges excluding pre-releases consistently)
devversion
force-pushed
the
build/correct-framework-peer-dependency
branch
from
2d222a7 to
747dddb
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current peer dependency for Angular CDK/Material v13 also allows
for Angular
v14.0.0-0. This might work practically since Angular FWv14 is usually compatible with Angular N-1 versions.
Although this peer dependency version is currently a little ambiguous since
it does not allow for all v14 pre-releases. Rather as per NPMs definition, the
current range does only allow for
v14.x.yandv14.0.0-(next|rc).X(excluding pre-releases for other minors)
It seems like it would be best to avoid this pre-release "range extension" in general
to avoid this ambiguity/inconsistency, while also fixing angular/angular-cli#22654.
In general, it seems reasonable to say that Angular CDK v13 is compatible
with Angular FW v13, and Angular FW v14 (both of these ranges excluding
pre-releases consistently)