Skip to content

refactor(multiple): remove PlatformModule usages #24366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 6, 2022

The PlatformModule is a noop so we don't need to import it.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 6, 2022
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, API goldens need to be updated.

The `PlatformModule` is a noop so we don't need to import it.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 6, 2022
@crisbeto crisbeto force-pushed the platform-module-cleanup branch from 050836d to 5df5d30 Compare February 6, 2022 10:30
@crisbeto crisbeto requested a review from a team as a code owner February 6, 2022 10:30
@devversion devversion removed the request for review from a team February 6, 2022 12:19
@wagnermaciel wagnermaciel merged commit 68e7bd0 into angular:master Feb 11, 2022
wagnermaciel pushed a commit that referenced this pull request Feb 11, 2022
The `PlatformModule` is a noop so we don't need to import it.

(cherry picked from commit 68e7bd0)
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
The `PlatformModule` is a noop so we don't need to import it.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants