Skip to content

build: update dev-infra package and format json files with prettier #24303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

devversion
Copy link
Member

Updates the dev-infra package and formats all .json files. The ng-dev format command will
format .json files by default when prettier is enabled.

cc. @Splaktar

@devversion devversion requested review from mmalerba and a team as code owners January 28, 2022 13:00
@devversion devversion added target: patch This PR is targeted for the next patch release merge safe labels Jan 28, 2022
@devversion devversion force-pushed the format-json branch 2 times, most recently from e1dbe00 to 9360f5f Compare January 28, 2022 13:24
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2022
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the lint failure in devkit-migration.ts.

@devversion devversion force-pushed the format-json branch 2 times, most recently from 7bbed06 to 15f2ba4 Compare February 2, 2022 18:10
renovate-bot and others added 2 commits February 3, 2022 16:27
With the latest build of the shared dev-infra tool, we have enabled
`.json` file formatting by default if the `prettier` formatter is
configured in `.ng-dev/format.ts`.

This commit formats all JSON files to ensure lint/the format check
continues to pass.
@zarend zarend merged commit cff93c8 into angular:master Feb 3, 2022
zarend pushed a commit that referenced this pull request Feb 3, 2022
…24303)

* build: update angular shared dev-infra code

* refactor: format all json files with `ng-dev format` command

With the latest build of the shared dev-infra tool, we have enabled
`.json` file formatting by default if the `prettier` formatter is
configured in `.ng-dev/format.ts`.

This commit formats all JSON files to ensure lint/the format check
continues to pass.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
(cherry picked from commit cff93c8)
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
…ngular#24303)

* build: update angular shared dev-infra code

* refactor: format all json files with `ng-dev format` command

With the latest build of the shared dev-infra tool, we have enabled
`.json` file formatting by default if the `prettier` formatter is
configured in `.ng-dev/format.ts`.

This commit formats all JSON files to ensure lint/the format check
continues to pass.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants