Skip to content

fix(material-experimental/mdc-form-field): incorrect alignment with border-box alignment #24222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

crisbeto
Copy link
Member

This came up in an internal discussion. The alignment of the prefix/suffix breaks if an app has * { box-sizing: border-box } which is fairly common.

…order-box alignment

This came up in an internal discussion. The alignment of the prefix/suffix breaks if an app has `* { box-sizing: border-box }` which is fairly common.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 18, 2022
@crisbeto crisbeto added the G This is is related to a Google internal issue label Jan 21, 2022
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting case, good to have a comment.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 21, 2022
@mmalerba mmalerba merged commit b3c9579 into angular:master Jan 24, 2022
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 31, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants