docs(material/datepicker): add note about locale data in date-fns #24067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
merge safe
P4
hartmair
suggested changes
Dec 16, 2021
| **Note:** if you're using the `MatDateFnsModule`, you have to provide the data object for your | ||
| locale to `MAT_DATE_LOCALE`, instead of the locale code. Locale data for `date-fns` can be imported | ||
| from `date-fns/locale`. | ||
|
|
There was a problem hiding this comment.
There is also MAT_DATE_FORMATS to provide (Otherwise an error occurs: RangeError: Format string contains an unescaped latin alphabet character o). Full working example:
import { DateFnsAdapter, MAT_DATE_FNS_FORMATS } from '@angular/material-date-fns-adapter';
import { DateAdapter, MAT_DATE_FORMATS, MAT_DATE_LOCALE } from '@angular/material/core';
import { deAT } from 'date-fns/locale';
{ provide: DateAdapter, useClass: DateFnsAdapter },
{ provide: MAT_DATE_LOCALE, useValue: deAT },
{ provide: MAT_DATE_FORMATS, useValue: MAT_DATE_FNS_FORMATS },
googlebot
added
the
cla: yes
|
@crisbeto - is this one ready for review? |
Adds a note about how locale data should be provided for users that consume the `date-fns` adapter. Fixes angular#24026.
crisbeto
force-pushed
the
24026/date-fns-locale-data
branch
from
c2d24ca to
330265a
Compare
|
This should be good to go @andrewseguin |
zarend
pushed a commit
that referenced
this pull request
Mar 14, 2022
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…gular#24067) Adds a note about how locale data should be provided for users that consume the `date-fns` adapter. Fixes angular#24026.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note about how locale data should be provided for users that consume the
date-fnsadapter.Fixes #24026.