Skip to content

fix(material/core): ripples not being clipped on safari in shadow dom #24029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

fix(material/core): ripples not being clipped on safari in shadow dom #24029

merged 1 commit into from
Jan 24, 2022

Conversation

crisbeto
Copy link
Member

Fixes that sometimes the ripples weren't being clipped to the host element when they're inside a component with shadow DOM encapsulation on Safari.

Fixes #24028.

@crisbeto
fix(material/core): ripples not being clipped on safari in shadow dom
54267d4 
Fixes that sometimes the ripples weren't being clipped to the host element when they're inside a component with shadow DOM encapsulation on Safari.

Fixes angular#24028.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 29, 2021
@crisbeto crisbeto requested a review from devversion November 29, 2021 10:03
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 29, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2021
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@mmalerba mmalerba merged commit e03a770 into angular:master Jan 24, 2022
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 31, 2022
@crisbeto @mmalerba
fix(material/core): ripples not being clipped on safari in shadow dom (…
1a80ee7 
…angular#24029)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(ripple): Ripple overflows element in Safari when using ShadowDOM
4 participants
@crisbeto @devversion @mmalerba @andrewseguin