Skip to content

build: fix source maps in dev-app due to missing source contents #23925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

devversion
Copy link
Member

Fixes the source-maps in the dev-app due to missing source contents
which could not be easily loaded through relative paths as the Bazel
execroot is not known to the e.g. Chrome devtools.

Fixes the source-maps in the dev-app due to missing source contents
which could not be easily loaded through relative paths as the Bazel
execroot is not known to the e.g. Chrome devtools.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Nov 8, 2021
@devversion devversion requested a review from crisbeto November 8, 2021 16:31
@devversion devversion requested review from jelbourn and a team as code owners November 8, 2021 16:31
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 8, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 8, 2021
@devversion devversion removed the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 10, 2021
@mmalerba mmalerba merged commit 513fb07 into angular:master Nov 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants