Skip to content

fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor #23735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor #23735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/cdk/overlay/position/connected-position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

/** Horizontal dimension of a connection point on the perimeter of the origin or overlay element. */
import {Optional} from '@angular/core';
export type HorizontalConnectionPos = 'start' | 'center' | 'end';

/** Vertical dimension of a connection point on the perimeter of the origin or overlay element. */
Expand Down Expand Up @@ -91,7 +90,7 @@ export class ConnectedOverlayPositionChange {
/** The position used as a result of this change. */
public connectionPair: ConnectionPositionPair,
/** @docs-private */
@Optional() public scrollableViewProperties: ScrollingVisibility,
public scrollableViewProperties: ScrollingVisibility,
) {}
}

Expand Down