refactor: remove any type from ts4.4 upgrade regarding
#23671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Pitch for this PR: one or two |
crisbeto
reviewed
Oct 1, 2021
Removes the `any` type used in the previous ts4.4 upgrade PR when refering to the style property on the element. Creates a new type to work around the built in `CSSStyleDeclaration` not including `webkitTapHighlightColor`.
|
note to caretaker: this will be safe to merge as long as it compiles internally. There is no need to actually run tests, should be fine as long as it builds. |
zarend
added
the
merge: caretaker note
|
|
andrewseguin
added
target: minor
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Oct 22, 2021
Removes the `any` type used in the previous ts4.4 upgrade PR when refering to the style property on the element. Creates a new type to work around the built in `CSSStyleDeclaration` not including `webkitTapHighlightColor`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
anytype used in the previous ts4.4 upgrade PR whenrefering to the style property on the element. Creates a new type to
work around the built in
CSSStyleDeclarationnot includingwebkitTapHighlightColor.