feat(material-experimental/mdc-tabs): switch to new theming API #23642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
mdc-tabs-new-api
branch
from
2111972 to
7f399e5
Compare
crisbeto
commented
Sep 26, 2021
| @mixin structural-styles { | ||
| @include mdc-tab.without-ripple($query: mdc-helpers.$mat-base-styles-query); | ||
| @include mdc-tab-indicator.core-styles($query: mdc-helpers.$mat-base-styles-query); | ||
|
|
There was a problem hiding this comment.
This mixin is somewhat small at the moment, but we'll need to add the theme-styles mixins to it once MDC fixes them.
andrewseguin
reviewed
Oct 5, 2021
Switches the MDC-based tabs to the new theming API. Note that while this uses the new mixins which clean up some of our overrides, it doesn't get us there completely in regards to the new API. Currently MDC's tabs mixins output the token values directly, rather than generating CSS variables for them. That being said, this still makes it easier to switch to CSS variables once they're available. These changes also introduce a new `structural-styles` mixin in `tabs-common` which centralizes the various structural styles we include from MDC. Previously they were scattered across multiple files.
crisbeto
force-pushed
the
mdc-tabs-new-api
branch
from
7f399e5 to
21ac749
Compare
|
Feedback has been addressed. |
andrewseguin
approved these changes
Oct 7, 2021
|
Closed in favor of #23642, which has identical code but the commit type is changed from |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the MDC-based tabs to the new theming API. Note that while this uses the new mixins which clean up some of our overrides, it doesn't get us there completely in regards to the new API. Currently MDC's tabs mixins output the token values directly, rather than generating CSS variables for them. That being said, this still makes it easier to switch to CSS variables once they're available.
These changes also introduce a new
structural-stylesmixin intabs-commonwhich centralizes the various structural styles we include from MDC. Previously they were scattered across multiple files.