Skip to content

chore: add license header to umd bundles #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2016

Conversation

devversion
Copy link
Member

  • Adds a license header to the UMD bundles. Similar to @angular core packages.

See https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js

* Adds a license header to the UMD bundles. Similar to @angular core packages.
@devversion devversion requested a review from jelbourn December 22, 2016 14:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 22, 2016
@@ -22,6 +24,12 @@ export const HTML_MINIFIER_OPTIONS = {
removeAttributeQuotes: false
};

export const LICENSE_BANNER = `/**
* @license Angular Material v${MATERIAL_VERSION}
* Copyright (c) 2016 Google, Inc. https://angular.io/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should link to material.angular.io instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think that would play a big role. Just switched it to material.angular.io

@jelbourn
Copy link
Member

LGTM, thanks!

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 22, 2016
@jelbourn jelbourn merged commit 1927814 into angular:master Dec 22, 2016
@devversion devversion deleted the chore/license-header branch December 22, 2016 17:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants