Skip to content

fix(material/datepicker): calendar reopening on spacebar selection #23336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix(material/datepicker): calendar reopening on spacebar selection #23336

merged 1 commit into from
Aug 20, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the Material calendar was reopening immediately when a date is selected using the spacebar on Firefox.

Fixes #23305.

@crisbeto
fix(material/datepicker): calendar reopening on spacebar selection
292bb74 
Fixes that the Material calendar was reopening immediately when a date is selected using the spacebar on Firefox.

Fixes angular#23305.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Aug 10, 2021
@crisbeto crisbeto requested a review from mmalerba August 10, 2021 17:03
@crisbeto crisbeto requested a review from a team as a code owner August 10, 2021 17:03
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 10, 2021
@josephperrott josephperrott removed the request for review from a team August 10, 2021 18:39
mmalerba
mmalerba reviewed Aug 17, 2021
View reviewed changes
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2021
@amysorto amysorto merged commit b761dbc into angular:master Aug 20, 2021
amysorto pushed a commit that referenced this pull request Aug 20, 2021
@crisbeto @amysorto
fix(material/datepicker): calendar reopening on spacebar selection (#…
1244e25 
…23336)

Fixes that the Material calendar was reopening immediately when a date is selected using the spacebar on Firefox.

Fixes #23305.

(cherry picked from commit b761dbc)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(datepicker): Hitting space key to select date reopens picker on Firefox
3 participants
@crisbeto @mmalerba @amysorto