Skip to content

refactor(material/stepper): remove deprecated APIs for version 13 #23328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 8, 2021

Removes all the stepper APIs that were marked as deprecated for version 13.

BREAKING CHANGE:

  • CdkStepper._orientation has been removed. Use CdkStepper.orientation instead.
  • The _document parameter from the CdkStepper constructor has been removed.
  • The _document parameter from the MatStepper constructor has been removed.
  • MatVerticalStepper has been removed. Use MatStepper instead.
  • MatHorizontalStepper has been removed. Use MatStepper instead.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release breaking changes labels Aug 8, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Aug 8, 2021
@crisbeto crisbeto requested a review from mmalerba August 8, 2021 13:26
@crisbeto crisbeto requested review from devversion, jelbourn and a team as code owners August 8, 2021 13:26
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2021
@crisbeto crisbeto force-pushed the v13-stepper-breaking-changes branch from 7a190a8 to 0a3a37a Compare August 8, 2021 13:38
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For breaking change PRs like this, can you add them to the tracker?

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 9, 2021
@josephperrott josephperrott removed the request for review from a team August 10, 2021 18:39
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel
Copy link
Contributor

@crisbeto This needs to be rebased

@crisbeto crisbeto force-pushed the v13-stepper-breaking-changes branch from c122c71 to dac9ae2 Compare September 17, 2021 14:47
@crisbeto
Copy link
Member Author

Rebased.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
Removes all the stepper APIs that were marked as deprecated for version 13.

BREAKING CHANGE:
* `CdkStepper._orientation` has been removed. Use `CdkStepper.orientation` instead.
* The `_document` parameter from the `CdkStepper` constructor has been removed.
* The `_document` parameter from the `MatStepper` constructor has been removed.
* `MatVerticalStepper` has been removed. Use `MatStepper` instead.
* `MatHorizontalStepper` has been removed. Use `MatStepper` instead.
@crisbeto crisbeto force-pushed the v13-stepper-breaking-changes branch from dac9ae2 to 7c7703d Compare January 3, 2022 09:15
@andrewseguin andrewseguin merged commit db126b5 into angular:master Feb 18, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants