-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental/mdc-paginator): add screen reader announcement for current range when navigating between pages #23285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent for current range when navigating between pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -27,7 +27,7 @@ | |||
</div> | |||
|
|||
<div class="mat-mdc-paginator-range-actions"> | |||
<div class="mat-mdc-paginator-range-label"> | |||
<div class="mat-mdc-paginator-range-label" aria-live="polite"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question here: what would happen if the user landed on a page with a bunch of paginators? Would their range labels all be queued up and announced on init or is this only going to fire when the text changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the native aria-live
they should be queued up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.