Skip to content

fix(material-experimental/mdc-paginator): add screen reader announcement for current range when navigating between pages #23285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

amysorto
Copy link
Contributor

No description provided.

…ent for current range when navigating between pages
@amysorto amysorto requested a review from jelbourn July 30, 2021 20:40
@amysorto amysorto requested a review from crisbeto as a code owner July 30, 2021 20:40
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2021
@amysorto amysorto added Accessibility This issue is related to accessibility (a11y) P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jul 30, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,7 +27,7 @@
</div>

<div class="mat-mdc-paginator-range-actions">
<div class="mat-mdc-paginator-range-label">
<div class="mat-mdc-paginator-range-label" aria-live="polite">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question here: what would happen if the user landed on a page with a bunch of paginators? Would their range labels all be queued up and announced on init or is this only going to fire when the text changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the native aria-live they should be queued up.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2021
@zarend zarend merged commit b3a6a0a into angular:master Aug 4, 2021
zarend pushed a commit that referenced this pull request Aug 4, 2021
…ent for current range when navigating between pages (#23285)

(cherry picked from commit b3a6a0a)
zarend pushed a commit that referenced this pull request Aug 4, 2021
…ent for current range when navigating between pages (#23285)

(cherry picked from commit b3a6a0a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants