Skip to content

build: install MDC canary dependencies through yarn #23251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

build: install MDC canary dependencies through yarn #23251

merged 1 commit into from
Jul 28, 2021

Conversation

crisbeto
Copy link
Member

Reworks the MDC canary script to use yarn install instead of going through yarn add in an attempt to avoid flakes on the CI.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 27, 2021
@crisbeto crisbeto requested review from devversion and mmalerba July 27, 2021 16:32
@crisbeto crisbeto requested a review from a team as a code owner July 27, 2021 16:32
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2021
@crisbeto
build: install MDC canary dependencies through yarn
ae4629f 
Reworks the MDC canary script to use `yarn install` instead of going through `yarn add` in an attempt to avoid flakes on the CI.
@crisbeto crisbeto force-pushed the mdc-canary-bump-again branch from 1b194ba to ae4629f Compare July 27, 2021 16:36
devversion
devversion approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this does the job. It's the same approach we've been taking on the FW snapshot builds.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 27, 2021
@mmalerba mmalerba merged commit c9e150c into angular:master Jul 28, 2021
mmalerba pushed a commit that referenced this pull request Jul 28, 2021
@crisbeto @mmalerba
build: install MDC canary dependencies through yarn (#23251)
23ec0b4 
Reworks the MDC canary script to use `yarn install` instead of going through `yarn add` in an attempt to avoid flakes on the CI.

(cherry picked from commit c9e150c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @mmalerba