ci: fix saucelabs browser crashing due to idle timeout #23240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Nit: hopeing => hoping |
devversion
force-pushed
the
ci/reduce-saucelabs-flakiness-and-duration
branch
from
2ecf1ac to
35073cb
Compare
devversion
added
merge safe
P2
|
Fixing the timeout/disconnect and updating to iOS14 reduced the 30min time to 10min |
In the past when the Angular Team reworked the Saucelabs Karma launcher the Saucelabs Selenium heartbeat has been removed in favor of people just increasing the Saucelabs `idleTimeout` to the max minutes their test will run. The `idleTimeout` is limited to a 16min right now, so we need to get back to the approach relying on a Selenium heartbeat. For reference: The heartbeat refers to the Karma launcher performing an arbitrary Selenium command every X seconds. This helps with keeping the Saucelabs browser alive. Currently we exceed the `idleTimeout` of 16min and the browsers start to crash. Karma re-starts the browser. This results in increased time for the Saucelabs test to ~30min from ~15min. We fix this by upating the Karma Saucelabs launcher to a version that has been improved by the Saucelabs team. We were always hestitant to updating because it took a lot effort to get the Saucelabs karma launcher stable (in the past it was _super_ flaky with the heartbeat and implementation), but it's worth another try given we now exceed the ~16min due to more tests being added. Long-term we want to switch the Saucelabs/Browserstack tests to fine-grained Bazel test targets that can be tested incrementally. There is work in progress for this, but it's not prioritized. This commit additionally updates the Saucelabs test from iOS13 to iOS14 with a more recent emulator, hoping for better specs of the Saucelabs VM and emulator. Note: We also need to add a new Yarn resolution that updates nested `https-proxy-agent` dependencies. Packages like the browserstack launcher install old versions that patch the NodeJS native `http.request` method and break `webdriverio` starting a remote Saucelabs session.
devversion
force-pushed
the
ci/reduce-saucelabs-flakiness-and-duration
branch
from
35073cb to
41976c0
Compare
mmalerba
pushed a commit
that referenced
this pull request
Jul 27, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message