fix(material-experimental/mdc-menu): increase specificity of menu pan… #23178
Conversation
google-cla
bot
added
the
cla: yes
wagnermaciel
force-pushed
the
fix-mdc-menu-positioning
branch
from
e4d1c3a to
bc39580
Compare
|
|
||
| // We need to increase the specificity for these styles to ensure we are not overriden by MDC's | ||
| // .mdc-menu-surface styles. This can happen if the MDC styles are loaded in after our styles. | ||
| .mat-mdc-menu-panel.mat-mdc-menu-panel { |
There was a problem hiding this comment.
In what case would MDC's menu styles come in after ours? We should have control over the load order in this case.
There was a problem hiding this comment.
I have already run into a case internally where this happens, but I'm not sure how they managed to cause it
There was a problem hiding this comment.
Is it conflicting with our styles or MDC's? It might be the same issue I was trying to solve with #22562. I think this is fine for now, but we should just understand why it's happening.
There was a problem hiding this comment.
I'm not certain, but if that were the case I should be able to reproduce the issue on our devapp, but I cannot
For context, the app which was able to hit this edge case had a lot of duplicate css (I counted 12 <styles> divs with MDC's menu styles and 6 with our styles). I assumed it was something with the way they were importing styles
wagnermaciel
force-pushed
the
fix-mdc-menu-positioning
branch
from
bc39580 to
0fb1126
Compare
|
|
||
| // We need to increase the specificity for these styles to ensure we are not overriden by MDC's | ||
| // .mdc-menu-surface styles. This can happen if the MDC styles are loaded in after our styles. | ||
| .mat-mdc-menu-panel.mat-mdc-menu-panel { |
There was a problem hiding this comment.
Is it conflicting with our styles or MDC's? It might be the same issue I was trying to solve with #22562. I think this is fine for now, but we should just understand why it's happening.
wagnermaciel
added
the
target: patch
…el styles * We had some order-dependent styles that would be overridden if MDCs styles got loaded after ours. We are increasing the specificity of the menu panel styles to prevent these styles from being overriden when this edge case is hit
wagnermaciel
force-pushed
the
fix-mdc-menu-positioning
branch
from
0fb1126 to
9b06c80
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…el styles
got loaded after ours. We are increasing the specificity of the menu panel
styles to prevent these styles from being overriden when this edge
case is hit