Skip to content

build: fix checkbox theme error with latest MDC canary #23165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

build: fix checkbox theme error with latest MDC canary #23165

merged 1 commit into from
Jul 14, 2021

Conversation

crisbeto
Copy link
Member

Fixes an error that is thrown, because the MDC mixin we were using was renamed.

@crisbeto
build: fix checkbox theme error with latest MDC canary
90738af 
Fixes an error that is thrown, because the MDC mixin we were using was renamed.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jul 14, 2021
@crisbeto crisbeto requested a review from a team as a code owner July 14, 2021 13:45
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2021
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2021
@wagnermaciel
Copy link
Contributor

@crisbeto This has merge conflicts with 12.1.x. Can this be target: minor instead?

@crisbeto
Copy link
Member Author

Yep, changed.

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 14, 2021
@wagnermaciel wagnermaciel merged commit 5e771a7 into angular:master Jul 14, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @wagnermaciel @devversion @andrewseguin