Skip to content

fix(material/radio): hidden circle visible on some zoom levels #23154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/material/radio/radio.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,20 @@ $ripple-radius: 20px;

// The inner circle for the radio, shown when checked.
.mat-radio-inner-circle {
$transition-duration: 280ms;
$base-transition: transform ease $transition-duration, background-color ease $transition-duration;
border-radius: 50%;
box-sizing: border-box;
display: block;
height: $size;
left: 0;
position: absolute;
top: 0;
transition: transform ease 280ms, background-color ease 280ms;
// On some zoom levels the `scale(0.001)` from below can cause the circle to be shown as a 1x1
// dot (see #22036). Ensure that it's hidden using `opacity`. There's a slight transition with
// a long delay so that switching the opacity only applies after the `transform` is done.
opacity: 0;
transition: $base-transition, opacity linear 1ms $transition-duration;
width: $size;

// Note: This starts from 0.001 instead of 0, because transitioning from 0 to 0.5 causes
Expand All @@ -84,19 +90,21 @@ $ripple-radius: 20px;
// force browser to show background-color when using the print function
@include vendor-prefixes.private-color-adjust(exact);

._mat-animation-noopable & {
transition: none;
}

.mat-radio-checked & {
transform: scale(0.5);
opacity: 1;
transition: $base-transition;

@include a11y.high-contrast(active, off) {
// Since we use a background color to render the circle, it won't be
// displayed in high contrast mode. Use a border as a fallback.
border: solid private.private-div($size, 2);
}
}

._mat-animation-noopable & {
transition: none;
}
}

// Text label next to radio.
Expand Down