fix(material/table): switch back to class-based styling for flex tables #23153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an earlier PR we switched the flex-based table styles to target the tag names, rather than classes in order to support flex tables in MDC. The problem with targeting tag names is that it doesn't allow our styles to be applied to other elements within the table. E.g. in angular#22349 the user isn't able to target the "no data" row. These changes switch back to targeting classes and add some styles to prevent the flex-specific styles from bleeding into the table-based ones. Fixes angular#22349.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
andrewseguin
approved these changes
Jul 15, 2021
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
| // Workaround for https://goo.gl/pFmjJD in IE 11. Adds a pseudo | ||
| // element that will stretch the row the correct height. See: | ||
| // https://connect.microsoft.com/IE/feedback/details/802625 | ||
| &::after { |
There was a problem hiding this comment.
Do we need this workaround for IE 11?
andrewseguin
removed
the
P3
josephperrott
added
action: cleanup
|
Is anybody working on this? |
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmit of #22350 which was merged in by accident.
In an earlier PR we switched the flex-based table styles to target the tag names, rather than classes in order to support flex tables in MDC. The problem with targeting tag names is that it doesn't allow our styles to be applied to other elements within the table. E.g. in #22349 the user isn't able to target the "no data" row.
These changes switch back to targeting classes and add some styles to prevent the flex-specific styles from bleeding into the table-based ones.
Fixes #22349.