Skip to content

build: clean up MDC exports config #23107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 3, 2021

Most of the exports we've excluded from the exports config are underscored APIs. These changes add an option that allows us to exclude exports based on on a regex and removes the underscored APIs from the config since they're private anyway.

Most of the exports we've excluded from the exports config are underscored APIs. These changes add an option that allows us to exclude exports based on on a regex and removes the underscored APIs from the config since they're private anyway.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 3, 2021
@crisbeto crisbeto requested a review from devversion July 3, 2021 11:05
@crisbeto crisbeto requested a review from a team as a code owner July 3, 2021 11:05
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 4, 2021
@wagnermaciel wagnermaciel merged commit c958afd into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
Most of the exports we've excluded from the exports config are underscored APIs. These changes add an option that allows us to exclude exports based on on a regex and removes the underscored APIs from the config since they're private anyway.

(cherry picked from commit c958afd)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants