Skip to content

build: fix wrong variable reference #23046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

build: fix wrong variable reference #23046

merged 1 commit into from
Jun 23, 2021

Conversation

crisbeto
Copy link
Member

A couple of conflicting PRs were merged in at the same time which is causing a build error, because an import was removed.

@crisbeto
build: fix wrong variable reference
771443c 
A couple of conflicting PRs were merged in at the same time which is causing a build error, because an import was removed.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jun 23, 2021
@crisbeto crisbeto requested a review from mmalerba June 23, 2021 04:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 23, 2021
@crisbeto crisbeto mentioned this pull request Jun 23, 2021
Merged
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 23, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 23, 2021
@mmalerba mmalerba merged commit 3531346 into angular:master Jun 23, 2021
mmalerba pushed a commit that referenced this pull request Jun 23, 2021
@crisbeto @mmalerba
build: fix wrong variable reference (#23046)
1cdbacc 
A couple of conflicting PRs were merged in at the same time which is causing a build error, because an import was removed.
mmalerba added a commit that referenced this pull request Jun 25, 2021
@mmalerba
Revert "build: fix wrong variable reference (#23046)"
204fffe 
This reverts commit 1cdbacc.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @mmalerba