Skip to content

fix(material-experimental/mdc-button): not disabling animations under noop animations module #23027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the MDC-based buttons weren't disabling their animations when noop animations are enabled.

… noop animations module

Fixes that the MDC-based buttons weren't disabling their animations when noop animations are enabled.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 20, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2021
@devversion
Copy link
Member

MDC does provide the animations feature target which we could also exclude if animations are disabled. Just wanted to see here why we manually set the transition (just to be on the same page). I'd assume dealing with the animation feature query is rather complicated, increases specificity etc.? If so, that makes sense to me.

@crisbeto
Copy link
Member Author

The problem is that MDC's mixins are written like:

@mixin mdc-button {
  .mdc-button {
    ...
  }
}

This means that the _mat-animation-noopable class has to be on a higher level in the DOM, whereas we set it on the button itself.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2021
@devversion
Copy link
Member

I see, that makes sense. Thanks for the clarification!

@andrewseguin andrewseguin merged commit 72ae5a2 into angular:master Jul 2, 2021
andrewseguin pushed a commit that referenced this pull request Jul 2, 2021
… noop animations module (#23027)

Fixes that the MDC-based buttons weren't disabling their animations when noop animations are enabled.

(cherry picked from commit 72ae5a2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants