Skip to content

docs(material/chips): remove unused field visible #22978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2021
Merged

docs(material/chips): remove unused field visible #22978

merged 1 commit into from
Jun 16, 2021

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2021
@jeripeierSBB
Copy link
Contributor Author

Further, I would suggest removing the following fields as they are not modifiable within the example. As an alternative, buttons could be added to toggle the state of the fields. If you like, I would further modify the example as wished.

  selectable = true;
  removable = true;
  addOnBlur = true;

crisbeto
crisbeto approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jun 15, 2021
@wagnermaciel wagnermaciel merged commit 5391cad into angular:master Jun 16, 2021
wagnermaciel pushed a commit that referenced this pull request Jun 16, 2021
@jeripeierSBB @wagnermaciel
docs(material/chips): remove unused field visible (#22978)
97e06fe 
(cherry picked from commit 5391cad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeripeierSBB @crisbeto @wagnermaciel