Skip to content

test(multiple): refactor unit tests of several components #22976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2021
Merged

test(multiple): refactor unit tests of several components #22976

merged 1 commit into from
Jun 16, 2021

Conversation

nitinmalave
Copy link
Contributor

Opening this PR as it is required to:

  • Refactor variables in several component unit tests to have constant type instead of let as this variables are not getting re-initialize during the test life-time.
  • All tests within a spec should be consistent with all other tests in repo.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 14, 2021
@nitinmalave nitinmalave force-pushed the refactor-unit-tests branch from fbd5262 to 69b8507 Compare June 14, 2021 18:04
mmalerba
mmalerba approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jun 14, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 16, 2021
@wagnermaciel wagnermaciel merged commit efabc01 into angular:master Jun 16, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitinmalave @mmalerba @wagnermaciel