feat(google-maps): add event emitter for gm_authFailure callback #22953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
kgajera
force-pushed
the
maps-auth-failure-callback-event-emitter
branch
from
309a6c3 to
390641c
Compare
devversion
requested review from
crisbeto and
mbehrlich
and removed request for
a team
crisbeto
requested changes
Jun 14, 2021
| @@ -245,6 +253,7 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy { | |||
| 'https://developers.google.com/maps/documentation/javascript/' + | |||
| 'tutorial#Loading_the_Maps_API'); | |||
| } | |||
| googleMapsWindow.gm_authFailure = () => this.authFailure.emit(); | |||
There was a problem hiding this comment.
I think that this will break if there are multiple maps on the page since each one will overwrite the auth failure callback on the previous map. We should do something like in the youtube-player: https://github.com/angular/components/blob/master/src/youtube-player/youtube-player.ts#L224
kgajera
force-pushed
the
maps-auth-failure-callback-event-emitter
branch
4 times, most recently
from
edc39a0 to
3afbba1
Compare
kgajera
force-pushed
the
maps-auth-failure-callback-event-emitter
branch
from
3afbba1 to
c7213c4
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit event from the
GoogleMapcomponent when thegm_authFailurecallback is called.Fixes #22163