-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(material/snack-bar): refactor variable type to const in snack-bar component unit tests #22774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(material/snack-bar): refactor variable type to const in snack-bar component unit tests #22774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but the branch needs to be rebased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, changes in 425edb5 look good. The PR shows more commits though, most likely because it isn't rebased on top of master
. Can you please fix that?
Hello @devversion, i am pretty new to this project and trying to contribute for first time in angular materials. I am not fully aware about rebasing branches in git. Can you please help me with the process to follow in order to get this commit merged in master? Previously i did "git rebase master" on my local branch and pushed the changes on remote branch. What can be done from here? Any help would be appreciated. Thank you! |
d715199
to
09ad4e7
Compare
…k-bar component unit tests style(material/snack-bar): fix tslint trailing whitespace issue in ci build
9141a22
to
b4b8104
Compare
Hello @devversion @crisbeto, I have rebased the branch on top of master and pushed all changes. All checks have passed as of now. Please take a look of PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Opening this PR as it is required to: