Skip to content

docs: update documentation for RippleGlobalOptions.animation #22767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

docs: update documentation for RippleGlobalOptions.animation #22767

merged 1 commit into from
May 24, 2021

Conversation

crisbeto
Copy link
Member

The doc string on RippleGlobalOptions.animation was incorrect, because the matRippleAnimation input takes precedence over the NoopAnimationsModule.

Fixes #21541.

@crisbeto
docs: update documentation for RippleGlobalOptions.animation
7f97979 
The doc string on `RippleGlobalOptions.animation` was incorrect, because the `matRippleAnimation` input takes precedence over the `NoopAnimationsModule`.

Fixes angular#21541.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels May 24, 2021
@crisbeto crisbeto requested a review from devversion May 24, 2021 13:27
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 24, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 24, 2021
@wagnermaciel wagnermaciel merged commit 70e029e into angular:master May 24, 2021
wagnermaciel pushed a commit that referenced this pull request May 24, 2021
@crisbeto @wagnermaciel
docs: update documentation for RippleGlobalOptions.animation (#22767)
14c5e6e 
The doc string on `RippleGlobalOptions.animation` was incorrect, because the `matRippleAnimation` input takes precedence over the `NoopAnimationsModule`.

Fixes #21541.

(cherry picked from commit 70e029e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(ripple): Incorrectly says that animations will be disabled from NoopAnimationsModule
3 participants
@crisbeto @devversion @wagnermaciel