Skip to content

docs: Fix typo in theming example #22765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

docs: Fix typo in theming example #22765

merged 1 commit into from
May 24, 2021

Conversation

Plondrein
Copy link
Contributor

No description provided.

@Plondrein Plondrein requested a review from jelbourn as a code owner May 23, 2021 15:01
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2021
@Plondrein
Copy link
Contributor Author

It looks like typo was made because of naming convention used for pre-built theme (pink-bluegray)

crisbeto
crisbeto approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels May 24, 2021
@wagnermaciel wagnermaciel merged commit c4f836c into angular:master May 24, 2021
wagnermaciel pushed a commit that referenced this pull request May 24, 2021
@Plondrein @wagnermaciel
docs: Fix typo in theming example (#22765)
54f53ed 
(cherry picked from commit c4f836c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Plondrein @crisbeto @wagnermaciel