Skip to content

docs(material/table): Correct checkbox label on select all checkbox #22748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

docs(material/table): Correct checkbox label on select all checkbox #22748

merged 1 commit into from
May 24, 2021

Conversation

dbosh88
Copy link
Contributor

@dbosh88 dbosh88 commented May 21, 2021

The example label for the select all/deselect all checkbox is reversed. The select all state is labeled "deselect all" and vice versa. This will correct those labels.

image

@dbosh88 dbosh88 requested a review from andrewseguin as a code owner May 21, 2021 01:45
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 21, 2021
@dbosh88 dbosh88 changed the title Correct checkbox label on select all checkbox docs(material/table): Correct checkbox label on select all checkbox May 21, 2021
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels May 21, 2021
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label May 24, 2021
@wagnermaciel
Copy link
Contributor

@dbosh88 There are some CircleCI failures for this PR

@andrewseguin
Copy link
Contributor

Just flakes for the integration tests, but youll want to fix the commit message to match the commit rules

@wagnermaciel wagnermaciel added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label May 24, 2021
@wagnermaciel wagnermaciel merged commit 31ffc5b into angular:master May 24, 2021
wagnermaciel pushed a commit that referenced this pull request May 24, 2021
@dbosh88 @wagnermaciel
docs(material/table): Correct checkbox label on select all checkbox (#…
b920852 
…22748)

Change the label on the "select all" checkbox to read "deselect" and "select" correctly

(cherry picked from commit 31ffc5b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbosh88 @wagnermaciel @andrewseguin