Skip to content

fix(material/checkbox): disable ripple animation under noop animations module #22706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

fix(material/checkbox): disable ripple animation under noop animations module #22706

merged 1 commit into from
May 21, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the checkbox doesn't disable its ripple animation when the noop animations module is enabled.

@crisbeto
fix(material/checkbox): disable ripple animation under noop animation…
c5cd77c 
…s module

Fixes that the checkbox doesn't disable its ripple animation when the noop animations module is enabled.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 15, 2021
@crisbeto crisbeto requested a review from devversion May 15, 2021 15:39
@crisbeto crisbeto requested a review from jelbourn as a code owner May 15, 2021 15:39
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 17, 2021
@wagnermaciel wagnermaciel merged commit 561a38d into angular:master May 21, 2021
wagnermaciel pushed a commit that referenced this pull request May 21, 2021
@crisbeto @wagnermaciel
fix(material/checkbox): disable ripple animation under noop animation…
5928896 
…s module (#22706)

Fixes that the checkbox doesn't disable its ripple animation when the noop animations module is enabled.

(cherry picked from commit 561a38d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @wagnermaciel