Skip to content

build: update and fix vendor prefixes rule #22704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021

Conversation

crisbeto
Copy link
Member

The no-prefixes lint rule was tied to a very old version of Autoprefixer which wasn't detecting some properties. These changes update to the latest version, adjust our code account for some breaking changes and fix the previously-undetected issues.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 15, 2021
@crisbeto crisbeto requested review from devversion, jelbourn, mmalerba and a team as code owners May 15, 2021 09:47
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2021
@crisbeto crisbeto force-pushed the stylelint-prefix-rule branch from d0fb8f4 to 07e3426 Compare May 15, 2021 12:17
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 17, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label May 17, 2021
@crisbeto crisbeto force-pushed the stylelint-prefix-rule branch from 07e3426 to 7be5355 Compare May 18, 2021 17:17
The `no-prefixes` lint rule was tied to a very old version of Autoprefixer which wasn't detecting some properties. These changes update to the latest version, adjust our code account for some breaking changes and fix the previously-undetected issues.
@crisbeto crisbeto force-pushed the stylelint-prefix-rule branch from 7be5355 to 551099a Compare May 18, 2021 17:22
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 18, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 21, 2021
@wagnermaciel wagnermaciel merged commit da57e01 into angular:master May 21, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants