Skip to content

test(material/slider): clean up harness testing setup #22670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021

Conversation

crisbeto
Copy link
Member

Now that we know that the MDC-based slider won't have the same API as the non-MDC version, we can avoid sharing the test harness tests and clean up some of the logic.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: minor This PR is targeted for the next minor release labels May 12, 2021
@crisbeto crisbeto requested a review from devversion May 12, 2021 06:19
@crisbeto crisbeto requested a review from mmalerba as a code owner May 12, 2021 06:19
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests fail because the mdc-slider/testing package references the harness_tests_lib target. That should be removed to make CI green.

@crisbeto crisbeto force-pushed the slider-testing-cleanup branch from 25ce6d8 to dfce8dc Compare May 12, 2021 16:09
Now that we know that the MDC-based slider won't have the same API as the non-MDC version, we can avoid sharing the test harness tests and clean up some of the logic.
@crisbeto crisbeto force-pushed the slider-testing-cleanup branch from dfce8dc to 5728fb4 Compare May 12, 2021 16:12
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 12, 2021
@mmalerba mmalerba merged commit d11ed52 into angular:master May 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants